Skip to content
This repository was archived by the owner on Apr 1, 2026. It is now read-only.

fix: allow attendee multiple day checkin#7623

Merged
MeghalBisht merged 6 commits into
fossasia:developmentfrom
maze-runnar:attendee-checkin
Aug 2, 2021
Merged

fix: allow attendee multiple day checkin#7623
MeghalBisht merged 6 commits into
fossasia:developmentfrom
maze-runnar:attendee-checkin

Conversation

@maze-runnar
Copy link
Copy Markdown
Contributor

@maze-runnar maze-runnar commented Jul 29, 2021

Fixes https://github.com/fossasia/open-event-frontend/issues/2016
recreation of #7480

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@auto-label auto-label Bot added the fix label Jul 29, 2021
@vercel
Copy link
Copy Markdown

vercel Bot commented Jul 29, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/52DHQ4UkdkZvKG6VyDcnTw3du8np
✅ Preview: https://open-event-frontend-git-fork-maze-runnar-attend-5e1828-eventyay.vercel.app

@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 29, 2021 •
edited
Loading

Codecov Report

Merging #7623 (f8ea325) into development (20cd2c7) will decrease coverage by 0.07%.
The diff coverage is 5.12%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #7623      +/-   ##
===============================================
- Coverage        19.82%   19.75%   -0.08%     
===============================================
  Files              602      603       +1     
  Lines             6980     7015      +35     
  Branches           149      149              
===============================================
+ Hits              1384     1386       +2     
- Misses            5569     5602      +33     
  Partials            27       27
Impacted Files Coverage Δ
.../controllers/events/view/tickets/attendees/list.js 0.00% <0.00%> (ø)
app/models/attendee.js 0.00% <ø> (ø)
.../cell/events/view/tickets/attendees/cell-action.js 6.66% <6.66%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20cd2c7...f8ea325. Read the comment docs.

@maze-runnar maze-runnar changed the title fix: allw attendee multiple day checkin fix: allow attendee multiple day checkin Jul 29, 2021
MeghalBisht
MeghalBisht reviewed Jul 29, 2021
View reviewed changes
Comment thread app/components/ui-table/cell/events/view/tickets/attendees/cell-action.js
return [];
}

get checkoutTimes() {
Copy link
Copy Markdown
Member

@MeghalBisht MeghalBisht Jul 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maze-runnar shouldn't these all be computed properties?

Copy link
Copy Markdown
Contributor Author

@maze-runnar maze-runnar Jul 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No

MeghalBisht
MeghalBisht reviewed Jul 29, 2021
View reviewed changes
Comment thread app/controllers/events/view/tickets/attendees/list.js Outdated
@maze-runnar @MeghalBisht
Update app/controllers/events/view/tickets/attendees/list.js
1feb559 
Co-authored-by: Meghal Bisht <mailtomeghu25@gmail.com>
@maze-runnar maze-runnar requested a review from MeghalBisht August 2, 2021 05:33
@MeghalBisht MeghalBisht merged commit fe75979 into fossasia:development Aug 2, 2021
@maze-runnar maze-runnar deleted the attendee-checkin branch August 2, 2021 16:26
@mariobehling
Copy link
Copy Markdown
Member

mariobehling commented Sep 13, 2021

The attendee checkin dropdown is unfortunately still not working, in particular when there is only one event day there is no menu choice.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@MeghalBisht MeghalBisht MeghalBisht approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

fix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Provide attendee checkin for each conference day on events with several days

3 participants

@maze-runnar @mariobehling @MeghalBisht